From 9d5a75ee0e3b25a4b535a30314bb8385e25bc0d4 Mon Sep 17 00:00:00 2001 From: Nikhil Badyal Date: Mon, 22 Apr 2024 21:29:03 +0530 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Don't=20build=20when=20unable=20?= =?UTF-8?q?to=20parse=20version?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/manager/release_manager.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/manager/release_manager.py b/src/manager/release_manager.py index 7604d57..5d466a0 100644 --- a/src/manager/release_manager.py +++ b/src/manager/release_manager.py @@ -3,7 +3,7 @@ from typing import Self from loguru import logger -from packaging.version import Version +from packaging.version import InvalidVersion, Version from src.app import APP @@ -18,4 +18,8 @@ class ReleaseManager(object): def should_trigger_build(self: Self, old_version: str, new_version: str) -> bool: """Function to check if we should trigger a build.""" logger.info(f"New version {new_version}, Old version {old_version}") - return Version(new_version) > Version(old_version) # type: ignore[no-any-return] + try: + return Version(new_version) > Version(old_version) # type: ignore[no-any-return] + except InvalidVersion: + logger.error("unable to parse version.") + return False